[8u-dev] RFR+RFA (S): 8225137: Clean up remaining CHECK_NULL -> THREAD return issues

[Hohensee, Paul]

No problem.

Paul

On 6/4/19, 1:09 PM, "Andrew John Hughes" <gnu.andrew at redhat.com> wrote:

    
    
    On 03/06/2019 18:58, Hohensee, Paul wrote:
    > Bug: https://bugs.openjdk.java.net/browse/JDK-8225137
    > Webrev: http://cr.openjdk.java.net/~phh/8225137/webrev.8u.00/
    > 
    > This is a cleanup after the backport of https://bugs.openjdk.java.net/browse/JDK-8064811. The patch avoids having the expansion of CHECK_NULL produce unreachable code. Matched against code in 11u to make sure that no trap handling is required at the modified call sites.
    > 
    > Thanks,
    > 
    > Paul
    > 
    
    This seems to mostly be a backport of JDK-8062808 (Turn on the
    -Wreturn-type warning) with the exception of the changes to
    perfData.hpp, which are in the OpenJDK 11 version of JDK-8064811, but
    not the 8u version for some reason.
    
    I have a backport of that I intend to propose, as I mentioned before,
    but I think such a change is best to wait until later in the week when
    we start the 8u232 cycle.
    
    JDK-8225137 could then be used to complete the backport of JDK-8064811
    in 8u.
    
    Thanks,
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew