[8u] RFR 8153732: Windows remote printer changes do not reflect in lookupPrintServices()

[Andrew John Hughes]

On 05/06/2019 16:07, Zhengyu Gu wrote:

snip...

> 
> Thanks.
> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8153732_8u/webrev.02/
> 

As I said in my previous review [0], I think it is inappropriate to be
making changes to existing thread creation as part of this patch.
Rather, the new remThr addition should be made consistent with existing
thread creation.

As you already alluded to, 9 has the new Thread API in JDK-8056152, but
8u does not, so the two constructor calls do not have the same behaviour.

[0] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-June/009564.html
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew