[8u] RFR 8153732: Windows remote printer changes do not reflect in lookupPrintServices()

Zhengyu Gu zgu at redhat.com
Wed Jun 5 18:24:52 UTC 2019



On 6/5/19 12:55 PM, Andrew John Hughes wrote:
> On 05/06/2019 16:07, Zhengyu Gu wrote:
> 
> snip...
> 
>>
>> Thanks.
>> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8153732_8u/webrev.02/
>>
> 
> As I said in my previous review [0], I think it is inappropriate to be
> making changes to existing thread creation as part of this patch.
> Rather, the new remThr addition should be made consistent with existing
> thread creation.
>  > As you already alluded to, 9 has the new Thread API in JDK-8056152, but
> 8u does not, so the two constructor calls do not have the same behaviour.

I see.

Updated and retested: 
http://cr.openjdk.java.net/~zgu/JDK-8153732_8u/webrev.03/

Thanks,

-Zhengyu

> 
> [0] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-June/009564.html
> 


More information about the jdk8u-dev mailing list