[8u] RFR: 8210761: libjsig is being compiled without optimization

[Andrew John Hughes]

On 26/06/2019 14:02, Severin Gehwolf wrote:
> On Wed, 2019-06-26 at 13:04 +0100, Andrew John Hughes wrote:
>>
>> On 25/06/2019 10:04, Severin Gehwolf wrote:
>>> Hi,
>>>
>>> Could somebody please review this 8u backport? The build system in 8 is
>>> different, especially hotspot makefiles. Note, libjsig.so is part of
>>> the hotspot build. The patch is different in 8 (over 11) due to this
>>> reason. This is a Linux-only change and should be low risk. Thoughts?
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210761
>>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/01/webrev/
>>>
>>> Change in JDK 11: http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/e7aa96dc0b1e
>>>
>>> Testing: Manual build of slowdebug/fastdebug/release on x86_64.
>>> Fastdebug/release builds receive the -O3 flag, slowdebug not. As
>>> expected.
>>>
>>> Thanks,
>>> Severin
>>>
>>
>> The 11u fix applies to all 'unix' platforms, as far as I can see. Should
>> the 8u equivalent not also be applied to the solaris, bsd and aix
>> subdirectories as well for consistency?
> 
> Here you go:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/02/webrev/
> 

This looks good. Thanks.

> I cannot really test on bsd, solaris or aix, though :( Appreciate any
> testers for those platforms.

Yeah, I expected this. I think we have two choices with these kind of
patches; either we apply changes only for GNU/Linux & let it diverge
from other platforms, or, when the fix is identical, as in this case, we
apply the fix across them all.

I think the latter is the better solution, especially when it is applied
to all platforms on the original JDK version, as it leaves anyone
working on that platform at a later date with just fixing any problems
raised by the changes, rather than being faced with having to go through
a backlog of changes.

As it stands, it sounds like only *BSD will be in this situation anyway,
thanks to Christoph's testing. Assuming that goes fine, I'm happy for
this to be pushed.

> 
> Thanks,
> Severin
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew