[8u-dev] RFR+RFA (M): JDK-8176100: [REDO][REDO] G1 Needs pre barrier on dereference of weak JNI handles

[Hohensee, Paul]

Thank you, Andrey. Pushed in my name since the author, Mikael Gerdin, is inactive.

From: Andrey Petushkov <andrey.petushkov at gmail.com>
Date: Tuesday, May 7, 2019 at 6:54 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: Dmitry Cherepanov <dcherepanov at azul.com>, Andrew Hughes <gnu.andrew at redhat.com>, "jdk8u-dev at openjdk.java.net" <jdk8u-dev at openjdk.java.net>
Subject: Re: [8u-dev] RFR+RFA (M): JDK-8176100: [REDO][REDO] G1 Needs pre barrier on dereference of weak JNI handles

Hi Paul, All,

hotspot/test/runtime tests for the build with the patch have passed on e6500-based machine

Regards,
Andrey

On Wed, May 1, 2019 at 12:36 AM Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:
Thank you, Dmitry. Now we just need ppc results.

Paul

On 4/29/19, 11:59 PM, "jdk8u-dev on behalf of Dmitry Cherepanov" <jdk8u-dev-bounces at openjdk.java.net<mailto:jdk8u-dev-bounces at openjdk.java.net> on behalf of dcherepanov at azul.com<mailto:dcherepanov at azul.com>> wrote:

    Hi Paul, Andrew,

    I tested this with Solaris builds (x86_64 and sparc) and the results look good. The build passed and running jtreg’s tests (hotspot/test/runtime) didn’t reveal any regression.

    Thanks,

    Dmitry

    > On Apr 24, 2019, at 7:38 AM, Andrew John Hughes <gnu.andrew at redhat.com<mailto:gnu.andrew at redhat.com>> wrote:
    >
    > On 23/04/2019 19:15, Hohensee, Paul wrote:
    >> Ping. And, may I have a jdk8u-fix-yes tag?
    >>
    >> On 4/11/19, 2:38 PM, "jdk8u-dev on behalf of Hohensee, Paul" <jdk8u-dev-bounces at openjdk.java.net<mailto:jdk8u-dev-bounces at openjdk.java.net> on behalf of hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:
    >>
    >>    Bug: https://bugs.openjdk.java.net/browse/JDK-8176100
    >>    Webrev: http://cr.openjdk.java.net/~phh/8176100/webrev.8u.01/
    >>
    >>    Original patch: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/b163435e40b3
    >>
    >>    Patch applies cleanly net of file names and line numbers, except that shell scripts are necessary for jdk8 to run the two new tests. Also, I don’t have facilities to test x86 32-bit, sparc or ppc, so I’d greatly appreciate someone trying it on those platforms.
    >>
    >>    Thanks,
    >>
    >>    Paul
    >>
    >>
    >>
    >
    > I saw the original post, but I'm waiting on the review outcome before
    > approving a patch of this size with arch-specific changes.
    >
    > I'd also like to see some response with regards x86 & ppc. I think sparc
    > may lack support, going forward, and I don't think Oracle were even
    > particularly maintaining Linux+SPARC. Last time I asked around, I
    > couldn't find anyone with a machine to test it on. It looks like there
    > may be some in the GCC compile farm now [0], so I'll try and take a
    > look, unless anyone has any better offers.
    >
    > [0] https://cfarm.tetaneutral.net/machines/list/
    > --
    > Andrew :)
    >
    > Senior Free Java Software Engineer
    > Red Hat, Inc. (http://www.redhat.com)
    >
    > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net<http://keys.gnupg.net>)
    > Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    > https://keybase.io/gnu_andrew