回复：RFR: 8223147: JFR Backport (to jdk8u)

[董登辉(卓昂)]

Hi Mario、Andrey and all,

We(Alibaba) provided below JFR patches some time ago(check previous Guangyu' discussion in this thread), which are incremental changes based on Azul' patchset.

1. Add thread sampling support:
http://cr.openjdk.java.net/~luchsh/jfr_cr/cr_thread_samp_20190326/

2. Add biasedLocking event support:
http://cr.openjdk.java.net/~luchsh/hs_biasedlock/
http://cr.openjdk.java.net/~luchsh/jdk_biasedlock/

3. Add G1 region type change event:
http://cr.openjdk.java.net/~luchsh/g1region_type_change_event

4. Add G1 heap summay event:
http://cr.openjdk.java.net/~luchsh/jfr_cr/cr_g1heapsum_hs_20190326/
http://cr.openjdk.java.net/~luchsh/jfr_cr/cr_g1heapsum_jdk_20190326/ 

In addition to events support, they also include fixes for some failed testcases, 
As repository has been created now(Thanks for Alexey' work), we are planning to proceed the integraion for these patches.
What's your comments?


Thanks,
Denghui


------------------------------------------------------------------
发件人：Mario Torre <neugens at redhat.com>
发送时间：2019年5月7日(星期二) 21:53
收件人：Andrey Petushkov <andrey at azul.com>
抄　送：jdk8u-dev <jdk8u-dev at openjdk.java.net>
主　题：Re: RFR: 8223147: JFR Backport (to jdk8u)

On Tue, May 7, 2019 at 1:20 PM Andrey Petushkov <andrey at azul.com> wrote:
>
> Hi All,

Hi Andrey, thanks for the patch!

> RFR for initial JFR backport to current state of jdk8u-jfr-incubator is here http://cr.openjdk.java.net/~apetushkov/8223147/
> Please could you review and hopefully approve

I'm going through it now, I'll get back to you as soon as possible!

> The changes are the same as in initial review request [1] except two fixes were added for the bugs found after integration
> of Alibaba's implementation of thread sampling (note that according to the plan Alibaba's patches are not included into this RFR)
> The webrev includes bug ids for all changes backported under it, however these are not separated on per-file basis

This is perfect, so we have proper tracking of the patches.

> One process question (thus Andrew in To), the new webrev currently only includes the code which applies to jdk8u-jfr-incubator
> repo, but what about aarch64 and aarch32 ports which are not available there? I don't see a reason to prevent them from
> having JFR and there is code ready for that ([1]). How could we proceed with integration of it?

You are right, it didn't occur to me that this code was not part of
the repository, but this is because the staging repo is forked from
jdk8u-dev which doesn't contain those ports.

I think we should indeed backport the other changes, perhaps once
everything is in mainline we can push into the shenandoah/arm/etc...
repositories individual patches?

Cheers,
Mario

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898