[8u] RFR 8055705: Rename UnixPrintServiceLookup and Win32PrintServiceLookup as a platform neutral class name

[Zhengyu Gu]

On 5/28/19 1:24 PM, Andrew John Hughes wrote:
> 
> 
> On 28/05/2019 17:59, Zhengyu Gu wrote:
>>
>>
>> On 5/28/19 12:50 PM, Andrew John Hughes wrote:
>>>
>>>
>>> On 28/05/2019 13:30, Zhengyu Gu wrote:
>>>> Hi,
>>>>
>>>> Please review this backport to 8u. The patch applied largely clean after
>>>> file path changes. But instead of using platform-dependent META-INFO
>>>> service configuration file, I kept old mechanism to avoid pulling in
>>>> more changesets, and updated service configuration in following files:
>>>>
>>>> src/solaris/classes/sun/print/services/javax.print.PrintServiceLookup
>>>> src/windows/classes/sun/print/services/javax.print.PrintServiceLookup
>>>>
>>>> JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8055705
>>>> Original patch:
>>>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/8278952344bc
>>>>
>>>> JDK8u backport:
>>>> http://cr.openjdk.java.net/~zgu/JDK-8055705-8u/webrev.00/
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>
>>> The webrev is not showing the file moves as renames, but as new files,
>>> making it hard to compare to 11u. Your previous webrev for 8153732 had
>>> it right.

Updated: http://cr.openjdk.java.net/~zgu/JDK-8055705-8u/webrev.01/

Now, it shows moves.

Thanks,

-Zhengyu

>>
>> Because original patch is not showing moves, but deletes and addes. e.g.
>>
>> --- /dev/null    Thu Jan 01 00:00:00 1970 +0000
>> +++
>> b/src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java Fri
>> Oct 10 09:03:28 2014 -0700
>>
>> ---
>> a/src/java.desktop/unix/classes/sun/print/UnixPrintServiceLookup.java
>> Fri Oct 10 16:07:18 2014 +0400
>> +++ /dev/null    Thu Jan 01 00:00:00 1970 +0000
>>
>>
>> -Zhengyu
>>
>>>
>>> Thanks,
>>>
> 
> 
> The original patch I'm looking at in 11u does:
> 
> $ hg export -R ../jdk11 -r 1ef2879dc7ad|grep ^rename
> rename from
> jdk/src/java.desktop/unix/classes/META-INF/services/javax.print.PrintServiceLookup
> rename to
> jdk/src/java.desktop/share/classes/META-INF/services/javax.print.PrintServiceLookup
> rename from
> jdk/src/java.desktop/unix/classes/META-INF/services/javax.print.StreamPrintServiceFactory
> rename to
> jdk/src/java.desktop/share/classes/META-INF/services/javax.print.StreamPrintServiceFactory
> rename from
> jdk/src/java.desktop/unix/classes/sun/print/UnixPrintServiceLookup.java
> rename to
> jdk/src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java
> rename from
> jdk/src/java.desktop/windows/classes/sun/print/Win32PrintServiceLookup.java
> rename to
> jdk/src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
> 
> Regardless, can we make sure they are renames in 8u?
> 
> Thanks,
>