[8u] RFR 8055705: Rename UnixPrintServiceLookup and Win32PrintServiceLookup as a platform neutral class name

[Andrew John Hughes]

On 28/05/2019 19:46, Zhengyu Gu wrote:
> 

> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8055705-8u/webrev.01/
> 
> Now, it shows moves.
> 
> Thanks,
> 
> -Zhengyu
> 
>>>

This version looks a lot better.

Can you elaborate more on why the service file renames aren't included?
As far as I can tell, it should be possible to move

src/solaris/classes/sun/print/services/javax.print.PrintServiceLookup
->
src/share/classes/sun/print/services/javax.print.PrintServiceLookup

jdk/src/solaris/classes/sun/print/service/javax.print.StreamPrintServiceFactory
->
jdk/src/share/classes/sun/print/services/javax.print.StreamPrintServiceFactory

and remove the Windows versions in the same way, avoiding what are now
identical files in windows and solaris subdirectories.

I don't see the need to mirror the rename which adds META-INF into the
path, from 8054834 e.g.

rename from
jdk/src/solaris/classes/sun/print/services/javax.print.PrintServiceLookup
rename to
jdk/src/java.desktop/unix/classes/META-INF/services/javax.print.PrintServiceLookup

rename from
jdk/src/solaris/classes/sun/print/services/javax.print.StreamPrintServiceFactory
rename to
jdk/src/java.desktop/unix/classes/META-INF/services/javax.print.StreamPrintServiceFactory

rename from
jdk/src/windows/classes/sun/print/services/javax.print.PrintServiceLookup
rename to
jdk/src/java.desktop/windows/classes/META-INF/services/javax.print.PrintServiceLookup

rename from
jdk/src/windows/classes/sun/print/services/javax.print.StreamPrintServiceFactory
rename to
jdk/src/java.desktop/windows/classes/META-INF/services/javax.print.StreamPrintServiceFactory

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew