[8u] RFR 8131778: java disables UseAES flag when using VIS=2 on sparc

Martin Balao mbalao at redhat.com
Thu Nov 21 03:50:30 UTC 2019


Hi,

I'd like to request a review for the 8u backport of 8131778 [1].

Webrev.00:

 *
http://cr.openjdk.java.net/~mbalao/webrevs/8131778/8131778.8u.hotspot.webrev.00/

Differences from JDK baseline patch:

 * src/cpu/x86/vm/vm_version_x86.cpp
  * 2nd hook does not apply cleanly because 8134553 [2] and 8073108 [3]
are not in 8u. Note: 8073108 [3] backport to 8u is in progress [4].
Manually applied change without further conflicts.

This backport is necessary for feature parity between OpenJDK and Oracle
JDK.

Testing:

I could verify there are no regressions in x86_64:

[martin at vmhost bin]$ ./java -XX:+UseAES -XX:UseSSE=2
-XX:+PrintFlagsFinal -version| grep UseAES
     bool UseAES                                   := true
                 {product}
     bool UseAESIntrinsics                          = false
                 {product}
openjdk version "1.8.0-internal-debug"
OpenJDK Runtime Environment (build
1.8.0-internal-debug-martin_2019_11_20_15_40-b00)
OpenJDK 64-Bit Server VM (build 25.71-b00-debug, mixed mode)

I don't have infrastructure to build and test on SPARC; but given that
there were no conflicts on SPARC part of the patch, I assume it's likely
to be okay.

Thanks,
Martin.-

--
[1] - https://bugs.openjdk.java.net/browse/JDK-8131778
[2] - https://bugs.openjdk.java.net/browse/JDK-8134553
[3] - https://bugs.openjdk.java.net/browse/JDK-8073108
[4] -
https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-November/010630.html



More information about the jdk8u-dev mailing list