[8u] RFR 8073108: Use x86 and SPARC CPU instructions for GHASH acceleration

[Andrew John Hughes]

On 22/11/2019 13:30, Yuri Gaevsky wrote:
> Hi Martin,
> 
>> I didn't know you have already proposed a backport for this bug. I
>> assumed nobody did because the ticket was not flagged with
>> "jdk8u-fix-request". Sorry.
> 
> There is no need to apologise, it's great to finally see the review for JDK-8073108
> is progressing. :-)
> 
> IIUC, the marking of the appropriate JBS issue with 'jdk8u-fix-request' is the *next step*
> in the backporting process. 
> 
> In summary, my reading  of  the related OpenJDK documents (see below) is that:
>   (a) the formal review should be done *before* setting 'jdk8u-fix-request' label in JBS;
>   (b) 'review request for backport' and 'push approval for backport' are different things.
> 
> [1] https://wiki.openjdk.java.net/display/jdk8u/Main
>   --- cut ---
>     If the backport requires more than just cosmetic changes (file location changes, copyright
>   header updates) to apply to the 8u tree, *it should first be submitted for review*.
>   Push approval for a fix is *then requested by setting the jdk8u-fix-request label* on
>   the original JBS bug.
>   --- cut ---
> 
> [2] https://wiki.openjdk.java.net/display/jdk8u/Guidelines+for+working+on+jdk8u
>   --- cut ---
>   In general we'll use the process in https://openjdk.java.net/projects/jdk-updates/approval.html.
>   ...
>   To request maintainer *approval* for a backport, tag your entry in the bug
>   database with "jdk8u-fix-request".
>   --- cut ---
> 
> [3] https://openjdk.java.net/projects/jdk-updates/approval.html
>   --- cut ---
>   JDK Updates: Requesting *push* approval for fixes
>   Rule 0
>   ...
>   An OpenJDK JDK Updates Author, Committer or Reviewer requesting their fix in a JDK Updates
>   repo MUST label the corresponding master/parent issue with jdk<release>u-fix-request
>   (where <release> denotes the feature release version, e.g. jdk10u-fix-request) in the JDK Bug System.
>   --- cut ---
> 
> [4] https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
>   --- cut ---
>   If (and only if) the original patch was modified, *get the change reviewed*
>     Note: *the change review is not the approval, which you would get at the next step*
>   --- cut ---
> 
> 

This is correct; a patch should be in a commit-ready state before
flagging for approval. I intend to comment on this in a separate thread
as it does seem to have caused some confusion.

If there are elements of the documentation that you think would benefit
from greater clarification, please let us know.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew