[8u] RFR 8073108: Use x86 and SPARC CPU instructions for GHASH acceleration

[Yuri Gaevsky]

Hi Martin,

Could you please clarify how is your patch different from the similar patch for JDK-8073108 [1] (or [2])?

NB:  another follow-up patch [3] is required to make that acceleration fully functional.

Thanks,
-Yuri

[1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-September/010493.html
[2] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-October/010409.html
[3] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-October/010437.html


-----Original Message-----
From: jdk8u-dev [mailto:jdk8u-dev-bounces at openjdk.java.net] On Behalf Of Martin Balao
Sent: Thursday, November 21, 2019 01:34 AM
To: jdk8u-dev at openjdk.java.net
Subject: [8u] RFR 8073108: Use x86 and SPARC CPU instructions for GHASH acceleration

Hi,

I'd like to request a review for the 8u backport of 8073108 [1].

Webrev.00:

 * http://cr.openjdk.java.net/~mbalao/webrevs/8073108/8073108.8u.webrev.00/

Differences from JDK patch:

Hotspot
--

 * Path changes

 * src/cpu/aarch64/vm/vm_version_aarch64.cpp
  * AArch64 changes do not apply to 8u
   * Will be proposed for
http://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/

 * src/cpu/ppc/vm/vm_version_ppc.cpp
  * 1st hook does not apply cleanly because 8u has 8185979 [2] [3]
already (8185979 is newer than 8073108 but was backported first).
Manually applied change without further conflicts.

 * src/cpu/x86/vm/assembler_x86.cpp
  * 1st hook does not apply cleanly because 8u does not have 8076276
[4]. Manually applied changes without further conflicts.

 * src/share/vm/runtime/globals.hpp
  * 1st hook does not apply cleanly because 8u does not have 8074459
[5]. Manually applied changes without further conflicts.

JDK
--

 * Path changes

Testing:

 * com/sun/crypto/provider/Cipher/AES/TestGHASH.java
  * Passes

 * hotspot/test/compiler/7184394
  * Passes

Thanks,
Martin.-

--
[1] - https://bugs.openjdk.java.net/browse/JDK-8073108
[2] - https://bugs.openjdk.java.net/browse/JDK-8185979
[3] - http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c4567d28f31f
[4] - https://bugs.openjdk.java.net/browse/JDK-8076276
[5] - https://bugs.openjdk.java.net/browse/JDK-8074459