[8u] RFR 8073108: Use x86 and SPARC CPU instructions for GHASH acceleration

Martin Balao mbalao at redhat.com
Thu Nov 21 16:10:33 UTC 2019


Hi Yuri,

I didn't know you have already proposed a backport for this bug. I
assumed nobody did because the ticket was not flagged with
"jdk8u-fix-request". Sorry.

I've not found significant differences between your backport and mine.
The only minor comment I have is that you missed the word "left" in "//
Shift left 128 bit value in xmm register by number of bytes." line
(src/cpu/sparc/vm/vm_version_sparc.cpp).

On 11/21/19 7:38 AM, Yuri Gaevsky wrote:
> Could you please clarify how is your patch different from the similar patch for JDK-8073108 [1] (or [2])?
> 

What's the difference between [1] and [2]?

> NB:  another follow-up patch [3] is required to make that acceleration fully functional.
> 

This one was on my list too. I'll not abstain from duplicating the work.
Thanks for letting me know.

Regards,
Martin.-

> Thanks,
> -Yuri
> 
> [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-September/010493.html
> [2] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-October/010409.html
> [3] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-October/010437.html
> 



More information about the jdk8u-dev mailing list