[8u] RFR: 8196969: JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE

[Severin Gehwolf]

On Fri, 2019-11-29 at 16:09 +0000, Hohensee, Paul wrote:
> Looks good.

Thanks for the review, Paul!

> Separately, how difficult would it be to backport the SA test infra? Should we consider doing it?

I haven't looked at it in detail, but it may be something we should
consider doing. I doubt it's difficult, but it'll be a chunk of work.

It basically amounts to looking at
test/hotspot/jtreg/serviceability/sa/ and checking what functionality
exists in 8u then porting it over. Not sure how much of the other test
support libraries would need to get backported too.

Thanks,
Severin

> Thanks,
> Paul
> 
> On 11/28/19, 5:49 AM, "jdk8u-dev on behalf of Severin Gehwolf" <jdk8u-dev-bounces at openjdk.java.net on behalf of sgehwolf at redhat.com> wrote:
> 
>     Hi,
>     
>     Could I please get a review of this OpenJDK 8u backport of 8196969
>     which fixes a potential NPE when attaching to a Java process via jstack
>     -F <pid> and observing compiled frames with a null debug offset. The
>     patch is the same as for JDK 11 and JDK 14 (modulo path changes), but
>     I've dropped the tests since the SA test infra doesn't exist in 8u.
>     
>     I've verified manually that the fix works.
>     
>     Bug: https://bugs.openjdk.java.net/browse/JDK-8196969
>     webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196969/jdk8/01/webrev/
>     original change: https://hg.openjdk.java.net/jdk/jdk/rev/516db52daad6
>     
>     Thoughts?
>     
>     Thanks,
>     Severin
>     
>     
>