[8u] RFR: JDK-8231584: Deadlock with ClassLoader.findLibrary and System.loadLibrary call

[Hohensee, Paul]

Hi, Anton, thanks for picking this up. Ryan has left Amazon, so probably isn't monitoring this list.

Your backport looks good to me: the library fix is easier to understand than was Ryan's Hotspot fix. One tiny nit: in Runtime.java, the 14 patch changed the indentation of the line containing "Directory separator should not appear in library name: ": it would be good to carry that over to 8.

Thanks,

Paul

On 10/16/19, 9:09 AM, "jdk8u-dev on behalf of Anton Kozlov" <jdk8u-dev-bounces at openjdk.java.net on behalf of akozlov at azul.com> wrote:

    Hi,
    
    Please review backport of https://bugs.openjdk.java.net/browse/JDK-8231584
    
    The change resolves a deadlock that was reported as JDK-8194653, but it have not fixed in openjdk 8u yet.
    
    Webrev: http://cr.openjdk.java.net/~akozlov/8231584/u8.webrev/
    
    Changes for backport are:
    * comment in ClassLoader.java updated to match to jdk/jdk
    * ClassLoader's initLibraryPaths called in different place of System that predates modules system
    * test lost import of package of CompilerUtils, it's package-less in 8u
    
    Thanks,
    Anton