RFR: Backport of JDK-8212071 to jdk8u-dev

[Severin Gehwolf]

Hi Mario,

On Wed, 2019-10-30 at 17:26 +0100, Mario Torre wrote:
> Hi Severin,
> 
> Yes, it's the 11 webrev, I posted here for reference since this patch
> applies cleanly with the exception of the paths, however the 11
> backport had to be modified. I can upload the 8 webrev of course if
> you would like.

I see. In that case sending this extra email is just noise, IMHO.

In general, I think it's acceptable if there are path changes only
between 11 and 8 to add a "Fix Request 8u" comment saying as much. It
doesn't need a review, just approval.

If you do want to send an email to jdk8u-dev for review, then it would
be nicer for the reviewer to upload the actual 8u patch. Does that make
sense?

Thanks,
Severin

> On Wed, Oct 30, 2019 at 4:46 PM Severin Gehwolf <sgehwolf at redhat.com> wrote:
> > Hi,
> > 
> > On Wed, 2019-10-30 at 16:01 +0100, Mario Torre wrote:
> > > Hi all,
> > > 
> > > I would like to backport the following bug to jdk8u-dev:
> > > 
> > > https://bugs.openjdk.java.net/browse/JDK-8212071
> > > 
> > > The original patch did not apply cleanly due to JDK-8217731, however
> > > the jdk11-dev patch applies without modifications (except from the
> > > path changes of course):
> > > 
> > > http://cr.openjdk.java.net/~neugens/8212071/webrev.00/
> > 
> > Are you sure this is an jdk8u webrev? It looks like an 11u webrev to
> > me. I'm confused.
> > 
> > Thanks,
> > Severin
> > 
> 
>