RFR: Backport of JDK-8212071 to jdk8u-dev

[Mario Torre]

On Wed, Oct 30, 2019 at 5:44 PM Severin Gehwolf <sgehwolf at redhat.com> wrote:
>
> Hi Mario,
>
> On Wed, 2019-10-30 at 17:26 +0100, Mario Torre wrote:
> > Hi Severin,
> >
> > Yes, it's the 11 webrev, I posted here for reference since this patch
> > applies cleanly with the exception of the paths, however the 11
> > backport had to be modified. I can upload the 8 webrev of course if
> > you would like.
>
> I see. In that case sending this extra email is just noise, IMHO.
>
> In general, I think it's acceptable if there are path changes only
> between 11 and 8 to add a "Fix Request 8u" comment saying as much. It
> doesn't need a review, just approval.
>
> If you do want to send an email to jdk8u-dev for review, then it would
> be nicer for the reviewer to upload the actual 8u patch. Does that make
> sense?

Well, the patch is really the same. the reason I sent the email is
that the patch is different from 14 to 11, but the 11 patch applies to
8 as is, so I think who approves the patch should be aware of this,
hence the email.

Cheers,
Mario

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898