[8u] RFR Backport of 8203324: Use out of scope in getMacOSXLocale of java_props_macosx.c:120

[Andrew John Hughes]

On 20/08/2019 14:49, Simon Tooke wrote:
> Backport request
> 
> I would like to request a backport of 8203324: (Use out of scope in
> getMacOSXLocale of java_props_macosx.c:120).
> 
> This backport would increase buildability with newer toolchains on macOS
> platforms.
> 
> The original patch does not import cleanly, because another issue [1]
> partially addressed the problem.  There are two buffers that have the
> same use-out-of-scope issue.  My patch addresses both buffers.  I am not
> suggesting backporting the entire fix for 8160199, as it could involve a
> change in behaviour to user code.
> 
> Thank you for your time,
> 
> -Simon
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8203324
> 
> original patch: http://hg.openjdk.java.net/jdk/jdk/rev/01e4ddc3c23f
> 
> modified webrev: 
> http://cr.openjdk.java.net/~stooke/webrevs/jdk-8203324-jdk8u/webrev.01/webrev.jdk.01/
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8160199
> 
> 
> 

Looks sensible to me. Approved.

Out of interest, is it possible to build on Mac OS X at present? I
remember you posted another patch to work on this.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew