[8u] RFR Backport of 8203324: Use out of scope in getMacOSXLocale of java_props_macosx.c:120

[Simon Tooke]

On 9/2/2019 1:48 PM, Andrew John Hughes wrote:
>
> On 20/08/2019 14:49, Simon Tooke wrote:
>> Backport request
>>
>> I would like to request a backport of 8203324: (Use out of scope in
>> getMacOSXLocale of java_props_macosx.c:120).
>>
>> This backport would increase buildability with newer toolchains on macOS
>> platforms.
>>
>> The original patch does not import cleanly, because another issue [1]
>> partially addressed the problem.  There are two buffers that have the
>> same use-out-of-scope issue.  My patch addresses both buffers.  I am not
>> suggesting backporting the entire fix for 8160199, as it could involve a
>> change in behaviour to user code.
>>
>> Thank you for your time,
>>
>> -Simon
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8203324
>>
>> original patch: http://hg.openjdk.java.net/jdk/jdk/rev/01e4ddc3c23f
>>
>> modified webrev: 
>> http://cr.openjdk.java.net/~stooke/webrevs/jdk-8203324-jdk8u/webrev.01/webrev.jdk.01/
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8160199
>>
>>
>>
> Looks sensible to me. Approved.
>
> Out of interest, is it possible to build on Mac OS X at present? I
> remember you posted another patch to work on this.
>
> Thanks,

I have an updated version of the patch [1], and I've actually run tier1
on it, although there are failures [2].

It's unclear which failures I should be expecting, but the patch does
produce a very useable JDK8u on current macOS using current Xcode.

I originally put the macOS patch out as a backport, but (since it's just
a small subset of the backport) perhaps I should do it as a new issue
that references the upstream issue?


[1] https://github.com/stooke/jdk8u-xcode10/tree/master/jdk8u-patch

[2]
https://github.com/stooke/jdk8u-xcode10/blob/master/current-jdk8u-tier1-failures.txt