[8u] 8178870: instrumentation.retransformClasses cause coredump

[Andrew John Hughes]

On 03/09/2019 13:24, Zhengyu Gu wrote:
> Hi Andrew
>>>
>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8178870-8u/webrev.01/
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>
>>>
>>>>
>>
>> This seems to contain 3 bug IDs. Please post a clean webrev for 8178870
>> once 8155951 is pushed.
> 
> Yes. JDK-8155951 is prerequisite and its changeset contains two bug fixes.
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8178870-8u/webrev.02/
> 
> Thanks,
> 
> -Zhengyu
> 
> 
> 
> 
>>
>> Thanks,
>>

This looks ok. I presume you intend to commit with the correct metadata,
as currently it says "imported patch JDK-8178870_coredump.patch"?

As this is one of the fixes we still intend to get into 8u232, please
flag the bug with jdk8u-critical-request and then push to
https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot when approved.

For the record, the change to scratch_classes is part of a big cleanup
in https://bugs.openjdk.java.net/browse/JDK-8155672, which itself is
part of the PermGen removal, so not something that can be backported as
it stands.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew