[8u] 8178870: instrumentation.retransformClasses cause coredump

[Zhengyu Gu]

On 9/11/19 10:04 PM, Andrew John Hughes wrote:
> 
> 
> On 03/09/2019 13:24, Zhengyu Gu wrote:
>> Hi Andrew
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8178870-8u/webrev.01/
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>
>>>>
>>>>
>>>>>
>>>
>>> This seems to contain 3 bug IDs. Please post a clean webrev for 8178870
>>> once 8155951 is pushed.
>>
>> Yes. JDK-8155951 is prerequisite and its changeset contains two bug fixes.
>>
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8178870-8u/webrev.02/
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>>
>>
>>>
>>> Thanks,
>>>
> 
> This looks ok. I presume you intend to commit with the correct metadata,
> as currently it says "imported patch JDK-8178870_coredump.patch"?

Of course. Otherwise, it won't push.

Thanks,

-Zhengyu

> 
> As this is one of the fixes we still intend to get into 8u232, please
> flag the bug with jdk8u-critical-request and then push to
> https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot when approved.
> 
> For the record, the change to scratch_classes is part of a big cleanup
> in https://bugs.openjdk.java.net/browse/JDK-8155672, which itself is
> part of the PermGen removal, so not something that can be backported as
> it stands.
> 
> Thanks,
>