[8u] RFR 8238225: Issues reported after replacing symlink at Contents/MacOS/libjli.dylib with binary

[Andrew Haley]

On 4/17/20 1:57 PM, Dmitry Cherepanov wrote:
> JBS: https://bugs.openjdk.java.net/browse/JDK-8238225
> original review: 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-January/064561.html
> patch for 11u: 
> https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/128739be82b6
> 
> webrev for 8u: 
> http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8238225/webrev.v0/
> 
> 1) src/macosx/bin/java_md_macosx.c
> 
> This part applies cleanly but needs refinement. The logic has been 
> expanded to cover 8u-specifics: if the libjli.dylib library was loaded 
> from MacOS bundle (i.e. realPathToSelf ends with “/MacOS/libjli.dylib”), 
> then check if it’s a JDK bundle (private JRE is in ../Home/jre) and then 
> check if it’s a JRE bundle (public JRE is in ../Home)

OK. I don't think we have an active reviewer here with MacOS experience, but
it looks reasonable.

> 2) testing part
> 
> Given that support for building native part of jtpeg tests is currently 
> missing in 8u (8072842), new shell script was created and used for 
> testing.  The java part of the test also includes additional changes 
> relative to 11u version 
> (http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8238225/JliLaunchTest.java.diff.v0). 
> The test fails without a fix and passes from the fixes (for JRE/JDK bundles)

OK.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671