[8u] TLSv1.3 RFR: 8245477: Adjust TLS tests location

Alexey Bakhtin alexey at azul.com
Mon Aug 10 13:35:58 UTC 2020


Hi Martin,

As discussed in [1] test/sun/security/ssl/SSLContextImpl/DefautlCacheSize.java should be moved to the
test/sun/security/ssl/SSLSessionContextImpl/ directory

I have updated the patch with this modification only:
http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245477/webrev.v4/
GIT diff : http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245477/webrev.v4/jdk.git.diff

Regards
Alexey
----
[1] - https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-August/012388.html

> On 29 Jul 2020, at 20:16, Martin Balao <mbalao at redhat.com> wrote:
> 
> On 7/29/20 12:12 PM, Alexey Bakhtin wrote:
>> Updated webrev at : http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245477/webrev.v3/
> 
> Hi,
> 
> The goal of Step 9 - 8245477 was to align JSSE regression test hierarchy
> to JDK-11 (changes introduced to main line by 8032473 [1]). This
> alignment will make easier to understand which tests were modified by
> the new SunJSSE engine, and do file-replacement in Steps 10 (removal of
> the existing file) and 11 (addition of the new version). In addition to
> file-relocation, minor path-related adjustments were made in Step 9
> (i.e.: paths to keystores used by some tests).
> 
> Path changes in tests (keystore locations):
> 
> * Ok.
> 
> Template library relocation (sun/security/ssl/templates ->
> javax/net/ssl/templates) and adjustment of tests that use it:
> 
> * Ok.
> 
> No other change in test files:
> 
> * Ok.
> 
> Relocations (review against 8032473)
> 
> * Ok.
> 
> Test regressions
> 
>  * It's not my expectation to verify no test regressions on this Step.
> Tests that do not enforce TLSv1.2 or below will probably fail if TLSv1.3
> is negotiated. Tests that depend on internal APIs will likely fail too.
> 
> The following comments and their replies are part of this review: [2],
> [3], [4] and [5].
> 
> With that said, Step 9 - 8245477 Webrev.03 looks good to me. Please hold
> the push until the whole series is review-approved and maintainer-approved.
> 
> When committing this patch, please include a reference to 8032473 in the
> message.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8032473
> [2] -
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012273.html
> [3] -
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012280.html
> [4] -
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012283.html
> [5] -
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012299.html
> 



More information about the jdk8u-dev mailing list