[8u] RFR Backport 8057003: Large reference arrays cause extremely long synchronization times

[Andrew Hughes]

On 14:46 Fri 17 Jul     , Hohensee, Paul wrote:
> I’d change the oops_do() comment to
> 
> // G1 does its own checking
> 
> because the assert has a general G1 check (i.e., UseG1GC) rather than a specific one. All uses of oops_do() by G1 will have to do their own checks, not just the array slice case that your current comment says.
> 
> Other than that, lgtm. I’ll sponsor the patch and add a ‘reviewed’ comment to the issue.
> 
> Thanks,
> Paul
> 

This was a bit difficult to follow at first, as a few hunks seem to
have moved files, but I agree it looks ok.

FWIW, JDK-8079082: "VerifyNoCSetOopsClosure is derived twice from Closure"
introduced the additional assert as part of its refactoring.

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222