[8u] RFR 8249158: THREAD_START and THREAD_END event posted in primordial phase

Jaroslav Bachorík jaroslav.bachorik at datadoghq.com
Wed Aug 19 09:32:41 UTC 2020


Hi Andrew,

On Wed, Jul 29, 2020 at 11:03 AM Andrew Dinn <adinn at redhat.com> wrote:
>
> Hi Jaroslav,
>
> On 28/07/2020 16:44, Jaroslav Bachorík wrote:
> > This patch is backing out the backport of JDK-8233197. The backport
> > changed slightly the init order and thus broke the expected behavior
> > of the JVMTI VMStart routine (more information in JIRA ticket).
> >
> > Since the original fix (JDK-8233197) is fixing an issue which can not
> > be hit in JDK 8 due to different implementation of the VM init phases
> > it makes sense to back out the backport and restore the original JVMTI
> > behavior.
> >
> > JIRA : https://bugs.openjdk.java.net/browse/JDK-8249158
> > CR    : http://cr.openjdk.java.net/~jbachorik/8249158
> >
> > The backout is fairly straightforward. When applied all jdk/jfr and
> > hotspot/runtime tests are passing.
> The backout looks correct to me except for one (non-functional) detail.
>
> At thread.cpp:3545 you now appear to have two copies of the comment
> explaining the significance of bug 4211085.

Aaah! Thanks! Fixed - http://cr.openjdk.java.net/~jbachorik/8249158/webrev.01/

-JB-

>
> regards,
>
>
> Andrew Dinn
> -----------
>


More information about the jdk8u-dev mailing list