[8u] RFR 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support

Andrew Hughes gnu.andrew at redhat.com
Sat Aug 22 01:52:03 UTC 2020


On 09:30 Fri 21 Aug     , Andrew Haley wrote:
> On 20/08/2020 18:20, Andrew Hughes wrote:
> > On 17:26 Wed 19 Aug     , Andrew Haley wrote:
> >>>
> >>> On 8/5/20 11:54 PM, Andrew Hughes wrote:
> >>>> I didn't go further with the review of this so far, because
> >>>> JDK-8144539 is one of the outstanding test backports for the
> >>>> SQLite patch as well. I intend to return to that bug trail
> >>>> shortly, and we can reconsider both patches once the test
> >>>> backports are resolved.
> >>>
> >>> I believe that 8144539 should not be a blocker for 8080462 because:
> >>> the overlap/conflict between them does not appear to be fundamental
> >>> -and has been addressed in the current backport proposal-; 8144539
> >>> does not look like a trivial backport -at least at first glance,
> >>> given the number of files affected-; and, 8144539 does not seem to
> >>> have the same priority than 8080462 -so a low priority backport is
> >>> currently blocking a high priority one-. Looks to me that 8144539 is
> >>> not even required for compatibility between JDKs, but 8080462
> >>> certainly is.
> >>
> >> We can't wait any longer for this. Martin, please feel free to commit
> >> http://cr.openjdk.java.net/~mbalao/webrevs/8080462/8080462.8u.jdk.webrev.01/
> >
> > I'm working on the dependencies for this right now. A few days is
> > hardly going to matter.
> >
> > I'll then review Martin's fix.
> 
> It has already been reviewed; it doesn't need another one.

No, what I reviewed previously was an earlier revision, not the current one.

> As Martin
> explained, we have a case of priority inversion here, where an
> important fix with customer need is blocked by a "wouldn't it be
> nice..." test fix, which doesn't make any sense.

It's a bit more than that. Getting the PKCS#11 testing sorted affects
at least one other fix as well, and this is an area where greater test
coverage is needed, as PKCS#11 isn't used in most setups.

> 
> Martin may, of course, wait for 8144539 if he wishes.
>

Martin and I are already working on this together.

The RFR for 8144539 is here:

https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-August/012517.html

> -- 
> Andrew Haley  (he/him)
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> https://keybase.io/andrewhaley
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
> 
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list