[8u] RFR: 8226575: OperatingSystemMXBean should be made container aware
Andrew Hughes
gnu.andrew at redhat.com
Tue Aug 25 16:19:18 UTC 2020
On 17:42 Tue 25 Aug , Severin Gehwolf wrote:
>
> Unfortunately not the case. It'll need a review.
>
Ok, consider this one reviewed then. Tag it for approval and I'll approve.
>
> > Incidentally, this RFR may well have been posted a month ago, but it
> > wasn't actionable without the dependent patch first being reviewed and
> > approved.
>
> Why? We already knew at the time that we want this patch (parity
> patch). The initial webrev didn't change (with the dependency in or
> not). As such, it could have been reviewed in my opinion.
>
Well, others may differ, but I would never review a patch that would
be applied to some future source code tree that doesn't yet exist (and
may never be applied if the dependency ends up being rejected)
I understand it may be easier for you to put out RFRs for everything
in your queue, but, from the review side, I find this confusing.
> Thanks,
> Severin
>
Thanks,
--
Andrew :)
Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the jdk8u-dev
mailing list