[8u] RFR: 8038723: Openup some PrinterJob tests
Jonathan Dowland
jdowland at redhat.com
Tue Dec 1 11:42:46 UTC 2020
Hi,
Please review this OpenJDK 8u port of JDK-8038723. This is a dependency
of JDK-6949753 which came up in the Backports scan, but discussing with
others might be independently interesting.
The patch introduces approx. 65 previously closed tests. The majority of
these are new file additions. The exception is
test/java/awt/print/PrinterJob/PrintTextTest.java.
In jdk9, this file was touched twice:
introduced by 8038723: Openup some PrinterJob tests
modified by 8132890: Text overlapping on dot matrix printers.
In jdk8u, 8132890 was already backported. The backporter introduced a
different version of the test which has not been committed to jdk9 or
any later version. That version of the test was an applet, and had a
corresponding PrintTextTest.html. For this backport, I have committed
the JDK9 version of the test and removed the (now superfluous)
PrintTextTest.html.
Please be sure to look at the changeset as well the webrev, since a
binary file test/java/awt/print/PrinterJob/CustomFont/A.ttf is added
which is not properly represented in the webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8038723
webrev: https://cr.openjdk.java.net/~jdowland/webrevs/JDK-8038723/webrev.00/
Testing: PrintTextTest is a manual-only test that requires the tester to
print out pages and compare the output to on-screen. I've run this test
once, it worked and the output looks correct.
Note: If this is accepted, the follow-up backport JDK-6949753 deletes
the test java/awt/print/PageFormat/PDialogTest.java.
Thanks,
--
Jonathan Dowland <jdowland at redhat.com>
Senior Software Engineer, OpenJDK, Red Hat
More information about the jdk8u-dev
mailing list