[8u] RFR: 8038723: Openup some PrinterJob tests

[Andrew Hughes]

On 11:42 Tue 01 Dec     , Jonathan Dowland wrote:
> Hi,
> 
> Please review this OpenJDK 8u port of JDK-8038723. This is a dependency
> of JDK-6949753 which came up in the Backports scan, but discussing with
> others might be independently interesting.
> 
> The patch introduces approx. 65 previously closed tests. The majority of
> these are new file additions. The exception is
> test/java/awt/print/PrinterJob/PrintTextTest.java.
> 
> In jdk9, this file was touched twice:
>     introduced by 8038723: Openup some PrinterJob tests
>     modified by   8132890: Text overlapping on dot matrix printers.
> 
> In jdk8u, 8132890 was already backported. The backporter introduced a
> different version of the test which has not been committed to jdk9 or
> any later version. That version of the test was an applet, and had a
> corresponding PrintTextTest.html. For this backport, I have committed
> the JDK9 version of the test and removed the (now superfluous)
> PrintTextTest.html.
> 
> Please be sure to look at the changeset as well the webrev, since a
> binary file test/java/awt/print/PrinterJob/CustomFont/A.ttf is added
> which is not properly represented in the webrev.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8038723
> webrev: https://cr.openjdk.java.net/~jdowland/webrevs/JDK-8038723/webrev.00/
> 
> Testing: PrintTextTest is a manual-only test that requires the tester to
> print out pages and compare the output to on-screen. I've run this test
> once, it worked and the output looks correct.
> 
> Note: If this is accepted, the follow-up backport JDK-6949753 deletes 
> the test java/awt/print/PageFormat/PDialogTest.java.
> 
> 
> Thanks,
> 
> -- 
> ���� Jonathan Dowland <jdowland at redhat.com>
> Senior Software Engineer, OpenJDK, Red Hat
> 

Looks like you beat me to upstreaming this one :)

http://icedtea.classpath.org/hg/icedtea8-forest/jdk/rev/a5d77ccaa809

Our patches are the same, with the bonus that you remembered to remove
the now redundant HTML file. From my own review of PrintTextTest.java,
I agree the 9u one is the definitive one.

Incidentally, you can use your new OpenJDK username as the commit
username now, rather than relying on Contributed-by.

Please flag for approval.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222