[JFR: jdk8u-jfr-incubator] RFR: JDK-8238589: Necessary code cleanup in JFR for JDK8u

[Aleksey Shipilev]

On 2/12/20 12:42 PM, Mario Torre wrote:
> hotspot:
> http://cr.openjdk.java.net/~neugens/8238589/webrev.00/

*) In systemDictionary.cpp, this assert seems legit, no need to remove it? It guards from calling
the branch when jfr_event_handler_proxy is accidentally uninitialized:

 1342       assert(jfr_event_handler_proxy != NULL, "invariant");

*) In biasedLocking.cpp, no wait, this disables revoke_bias call at L505, why?

 503 #if INCLUDE_JFR
 504       JavaThread* biased_locker = NULL;
 505       _status_code = revoke_bias((*_obj)(), false, false, _requesting_thread, &biased_locker);
 506       if (biased_locker != NULL) {
 507         _biased_locker_id = JFR_THREAD_ID(biased_locker);
 508       }
 509 #endif // INCLUDE_JFR
 510

> jdk:
> http://cr.openjdk.java.net/~neugens/8238589-jdk/webrev.00/

Looks fine.


-- 
Thanks,
-Aleksey