[JFR: jdk8u-jfr-incubator] RFR: JDK-8238589: Necessary code cleanup in JFR for JDK8u

[Mario Torre]

On Wed, Feb 12, 2020 at 12:49 PM Aleksey Shipilev <shade at redhat.com> wrote:>
> On 2/12/20 12:42 PM, Mario Torre wrote:
> > hotspot:
> > http://cr.openjdk.java.net/~neugens/8238589/webrev.00/
>
> *) In systemDictionary.cpp, this assert seems legit, no need to remove it? It guards from calling
> the branch when jfr_event_handler_proxy is accidentally uninitialized:
>
>  1342       assert(jfr_event_handler_proxy != NULL, "invariant");

But if jfr_event_handler_proxy is null then also class_name needs to
be null for the code to be executed, I don't think this is possible?

> *) In biasedLocking.cpp, no wait, this disables revoke_bias call at L505, why?
>
>  503 #if INCLUDE_JFR
>  504       JavaThread* biased_locker = NULL;
>  505       _status_code = revoke_bias((*_obj)(), false, false, _requesting_thread, &biased_locker);
>  506       if (biased_locker != NULL) {
>  507         _biased_locker_id = JFR_THREAD_ID(biased_locker);
>  508       }
>  509 #endif // INCLUDE_JFR
>  510

Oh, good catch, here's the updated webrev:

http://cr.openjdk.java.net/~neugens/8238589/webrev.02/

> > jdk:
> > http://cr.openjdk.java.net/~neugens/8238589-jdk/webrev.00/
>
> Looks fine.

Thanks for the review!

Cheers,
Mario

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898