Marlin renderer patches for jdk8u integration
Laurent Bourgès
bourges.laurent at gmail.com
Wed Feb 12 22:06:10 UTC 2020
Andrew,
Few quick answers below:
>
> I'm a little confused. When you write "Approved" below, do you mean that
> the bug has jdk8u-fix-yes and is ready for push? I don't see them in the
> approved-and-waiting queue, your previous e-mail suggested they needed
> approval and some still need review.
>
Yes there is a misunderstanding: I carefully reviewed zulu8 patches against
unshuffled patches I made from 9/10/11... to 8.
Approved just means the patch is good for me, as the original author (with
help from Jim Graham & Phil race).
Only m02 has the jdk8u-fix-request as I prefer a step by step approach.
Moreover I am not a webrev expert so I do not know how to perform
incremental webrevs without committing patches.
>
>
> > ----------------------------
> >
> > 2. m02.8145055.patch Review:
> >
> > ----------------------------
> >
> > Output: OK
> >
> > Status: Approved
> >
> > Comments:
> >
> > Same patch
> >
>
> Fine to skip review and go straight to jdk8u-fix-request.
>
That's my tip: waiting for your fix-yes + push ...
> > ----------------------------
> >
> > 3. m03.8144630.patch Review:
> >
> > ----------------------------
> >
> > Output: OK
> >
> > Status: Approved
> >
> >
> > Comments:
> >
> > RendererStats.java:
> >
> > import sun.awt.util.ThreadGroupUtils; => import
> sun.misc.ThreadGroupUtils;
> >
> >
> > Identation issues in diff => same
> >
>
> Needs a quick RFR.
>
I prepared files, RFR mail will come tomorrow.
...
> Assuming these need to be committed in this order, we can approve & push
> 8145055 (I'll look into that now) and you should post the RFR for 8144630.
>
Looks a good plan, then follow up in the bug list...
Laurent
More information about the jdk8u-dev
mailing list