Marlin renderer patches for jdk8u integration

[Andrew John Hughes]

On 12/02/2020 22:06, Laurent Bourgès wrote:
> Andrew,
> 
> Few quick answers below:
> 
> 
>     I'm a little confused. When you write "Approved" below, do you mean that
>     the bug has jdk8u-fix-yes and is ready for push? I don't see them in the
>     approved-and-waiting queue, your previous e-mail suggested they needed
>     approval and some still need review.
> 
> 
> Yes there is a misunderstanding: I carefully reviewed zulu8 patches
> against unshuffled patches I made from 9/10/11... to 8.
> Approved just means the patch is good for me, as the original author
> (with help from Jim Graham & Phil race).
> Only m02 has the jdk8u-fix-request as I prefer a step by step approach.
> 

Me too. In that case, I'll just ignore the status line in those comments.

> Moreover I am not a webrev expert so I do not know how to perform
> incremental webrevs without committing patches.

I believe you can use -r to specify the revision to compare against, but
it is much simpler to just proceed one by one. Such webrevs wouldn't be
much use for someone else to apply to their own repositories anyway.

> 
> 
> 
>     > ----------------------------
>     >
>     > 2. m02.8145055.patch Review:
>     >
>     > ----------------------------
>     >
>     > Output: OK
>     >
>     > Status: Approved
>     >
>     > Comments:
>     >
>     > Same patch
>     >
> 
>     Fine to skip review and go straight to jdk8u-fix-request.
> 
> 
> That's my tip: waiting for your fix-yes + push ...

Done.

> 
> 
>     > ----------------------------
>     >
>     > 3. m03.8144630.patch Review:
>     >
>     > ----------------------------
>     >
>     > Output: OK
>     >
>     > Status: Approved
>     >
>     >
>     > Comments:
>     >
>     > RendererStats.java:
>     >
>     > import sun.awt.util.ThreadGroupUtils; => import
>     sun.misc.ThreadGroupUtils;
>     >
>     >
>     > Identation issues in diff => same
>     >
> 
>     Needs a quick RFR.
> 
> 
> I prepared files, RFR mail will come tomorrow.

I look forward to it.

> 
> ...
> 
> 
>     Assuming these need to be committed in this order, we can approve & push
>     8145055 (I'll look into that now) and you should post the RFR for
>     8144630.
> 
> 
> Looks a good plan, then follow up in the bug list...
> 
> Laurent

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew