[8u] RFR: 8196969: JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE

[Andrew Hughes]

On 29/11/2019 16:42, Severin Gehwolf wrote:
> On Fri, 2019-11-29 at 16:09 +0000, Hohensee, Paul wrote:
>> Looks good.
> 
> Thanks for the review, Paul!
> 
>> Separately, how difficult would it be to backport the SA test infra? Should we consider doing it?
> 
> I haven't looked at it in detail, but it may be something we should
> consider doing. I doubt it's difficult, but it'll be a chunk of work.
> 
> It basically amounts to looking at
> test/hotspot/jtreg/serviceability/sa/ and checking what functionality
> exists in 8u then porting it over. Not sure how much of the other test
> support libraries would need to get backported too.
> 
> Thanks,
> Severin
> 
>> Thanks,
>> Paul
>>

Could we not include the tests but ProblemList them for now? I'm very
wary of just dropping tests on the floor, because it means someone else
needs to find and restore them under a separate bug later. You probably
need to knock the 'jtreg' out of the path so it fits into the current
OpenJDK 8u setup.

JDK-8081037: "serviceability/sa/ tests time out on Windows" (introduces
LingeredApp.java) and JDK-8190198: "SA: Framework for writing 'jhsdb
clhsdb' commands tests and testcases for some of the commands" seem to
be the key issues here, but there are probably others.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222