[8u] RFR 8167409: Invalid value passed to critical JNI function

[Andrew Hughes]

On 03/12/2019 06:11, Yangfei (Felix) wrote:
> Hi,
> 
> 
> 
> Please review 8u backport of 8167409.
> 
> 
> 
> Original bug:
> 
>   https://bugs.openjdk.java.net/browse/JDK-8167409
> 
> http://hg.openjdk.java.net/jdk/jdk/rev/11b8ac93804c
> 
> 
> 
> Original patch does not apply cleanly to 8u due to path differences and missing file.
> 
> 
> 
> 8u webrev:
> 
>   http://cr.openjdk.java.net/~fyang/8167409-8u-backport/webrev.00/
> 
> 
> 
> This updated copyright years for files changed or added.
> 
> Also added one shell script Test8167409.sh to run the newly added test case in the original patch.
> 
> 
> 
> Testing: Run full jtreg test with a x86-64 release build.
> 
>        Newly add test case fail without the patch and pass with the patch.
> 
> 
> 
> Thanks,
> 
> Felix
> 

Was the script based on one of the existing ones? It looks similar.

Generally happy with the patch, but would omit the copyright header
changes, as they are just going to create problems for future backports.
Also, the /runtime should probably be dropped from the test path as
other tests in 8u aren't under the runtime subdirectory.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222