[8u] RFR 8167409: Invalid value passed to critical JNI function

[Yangfei (Felix)]

> -----Original Message-----
> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
> Sent: Tuesday, February 18, 2020 8:43 PM
> To: Yangfei (Felix) <felix.yang at huawei.com>; jdk8u-dev at openjdk.java.net
> Subject: Re: [8u] RFR 8167409: Invalid value passed to critical JNI function
> 
> 
> On 03/12/2019 06:11, Yangfei (Felix) wrote:
> > Hi,
> >
> >
> > Please review 8u backport of 8167409.
> >
> >
> > Original bug:
> >
> >   https://bugs.openjdk.java.net/browse/JDK-8167409
> >
> > http://hg.openjdk.java.net/jdk/jdk/rev/11b8ac93804c
> >
> >
> > Original patch does not apply cleanly to 8u due to path differences and
> missing file.
> >
> >
> > 8u webrev:
> >
> >   http://cr.openjdk.java.net/~fyang/8167409-8u-backport/webrev.00/
> >
> >
> > This updated copyright years for files changed or added.
> >
> > Also added one shell script Test8167409.sh to run the newly added test case
> in the original patch.
> >
> >
> > Testing: Run full jtreg test with a x86-64 release build.
> >
> >        Newly add test case fail without the patch and pass with the patch.
> >
> 
> Was the script based on one of the existing ones? It looks similar.

Yes, modified from: hotspot/test/runtime/7107135/Test7107135.sh  

> Generally happy with the patch, but would omit the copyright header changes,
> as they are just going to create problems for future backports.

Do you mean the Copyright years update in these files?  

> Also, the /runtime should probably be dropped from the test path as other
> tests in 8u aren't under the runtime subdirectory.

Good suggestion.  I can propose a new webrev if you want.  


Thanks,
Felix