[Ping] Re: Request for Approval: Backport of 8146792 : Predicate moved after partial peel may lead to broken graph

[Yangfei (Felix)]

Hi Paul,

  Thanks for bring this back.  
  The 8u backport patch still applies: http://cr.openjdk.java.net/~fyang/8146792-backport/webrev.00/ 
  And it still works for the test case provided on : https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-August/009947.html 

Best regards,
Felix

> 
> Lgtm. This one dropped through the cracks. :(
> 
> Paul
> 
> On 8/7/19, 4:43 AM, "jdk8u-dev on behalf of Yangfei (Felix)"
> <jdk8u-dev-bounces at openjdk.java.net on behalf of felix.yang at huawei.com>
> wrote:
> 
> 
>     I saw your approval flag in the bug database, but there was no mention of
> whether the patch applied cleanly or not. I see no webrev link either there or in
> this e-mail. Can you clarify what you mean by "almost clean"
>     or maybe just provide a webrev for review?
> 
>     Hi,
> 
>         Sorry, I should have sent the webrev in my first e-mail.
> 
>         http://cr.openjdk.java.net/~fyang/8146792-backport/webrev.00/
> 
>         The only difference: the following change from the original patch is
> not needed as it is already there in the 8u repo.
> 
>     --- src/share/vm/opto/loopPredicate.cpp Tue Jan 12 10:44:41 2016 -1000
>     +++ src/share/vm/opto/loopPredicate.cpp Mon Jan 11 16:02:42 2016
> +0100
>     @@ -665,6 +689,7 @@
> 
>        if (scale != 1) {
>          ConNode* con_scale = _igvn.intcon(scale);
>     +    set_ctrl(con_scale, C->root());
>          max_idx_expr = new MulINode(max_idx_expr, con_scale);
>          register_new_node(max_idx_expr, ctrl);
>          if (TraceLoopPredicate) predString->print("* %d ", scale);
> 
>     Thanks,
>     Felix
>