[Ping] Re: Request for Approval: Backport of 8146792 : Predicate moved after partial peel may lead to broken graph

[Andrew John Hughes]

On 21/01/2020 21:45, Hohensee, Paul wrote:
> Lgtm. This one dropped through the cracks. :(
> 
> Paul
> 
> On 8/7/19, 4:43 AM, "jdk8u-dev on behalf of Yangfei (Felix)" <jdk8u-dev-bounces at openjdk.java.net on behalf of felix.yang at huawei.com> wrote:
> 
>     
>     I saw your approval flag in the bug database, but there was no mention of whether the patch applied cleanly or not. I see no webrev link either there or in this e-mail. Can you clarify what you mean by "almost clean"
>     or maybe just provide a webrev for review?
>     
>     Hi,
>     
>         Sorry, I should have sent the webrev in my first e-mail.
>     
>         http://cr.openjdk.java.net/~fyang/8146792-backport/webrev.00/
>     
>         The only difference: the following change from the original patch is not needed as it is already there in the 8u repo.
>     
>     --- src/share/vm/opto/loopPredicate.cpp Tue Jan 12 10:44:41 2016 -1000
>     +++ src/share/vm/opto/loopPredicate.cpp Mon Jan 11 16:02:42 2016 +0100
>     @@ -665,6 +689,7 @@
>     
>        if (scale != 1) {
>          ConNode* con_scale = _igvn.intcon(scale);
>     +    set_ctrl(con_scale, C->root());
>          max_idx_expr = new MulINode(max_idx_expr, con_scale);
>          register_new_node(max_idx_expr, ctrl);
>          if (TraceLoopPredicate) predString->print("* %d ", scale);
>     
>     Thanks,
>     Felix
>     
> 

It looks like I got as far as opening the bug up in my web browser... :/

Anyway, patch looks good to me too. Seems the set_ctrl addition was made
by the 8u backport of JDK-8173770.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew