[RFR] [8u-JFR] 8238076: Fix OpenJDK 7 Bootstrap Broken by JFR Backport

Aleksey Shipilev shade at redhat.com
Wed Jan 29 07:37:10 UTC 2020


On 1/29/20 4:45 AM, Andrew John Hughes wrote:
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8238076/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8238076

Looks fine.

There are little nits that could be fixed, but no need if that invalidates testing already done.

For example:
 - interfaces are implicitly static, so "static interface" is redundant
 - "delimiter" can be final
 - "elements" can be final and eagerly initialized in constructor
 - "elements" can be ArrayList

-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list