[RFR] [8u-JFR] 8238076: Fix OpenJDK 7 Bootstrap Broken by JFR Backport

[Andrew John Hughes]

On 29/01/2020 07:37, Aleksey Shipilev wrote:
> On 1/29/20 4:45 AM, Andrew John Hughes wrote:
>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8238076/webrev.01/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8238076
> 
> Looks fine.
> 
> There are little nits that could be fixed, but no need if that invalidates testing already done.
> 
> For example:
>  - interfaces are implicitly static, so "static interface" is redundant
>  - "delimiter" can be final

Yeah, you can tell I did this one quickly to see if it would work.

Fixed: https://cr.openjdk.java.net/~andrew/openjdk8/8238076/webrev.02/

>  - "elements" can be final and eagerly initialized in constructor

No idea why I wrote it like that now :) Also changed in the above.

>  - "elements" can be ArrayList
> 
Hmm... it can also be a LinkedList and, given this is a case where we
only append and then finally iterate over the whole list sequentially,
it seemed a good case for one. Not that it makes much difference either
way in a build tool.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew