[RFR] [8u-JFR] 8238076: Fix OpenJDK 7 Bootstrap Broken by JFR Backport

Andrew John Hughes gnu.andrew at redhat.com
Wed Jan 29 08:24:55 UTC 2020



On 29/01/2020 07:37, Aleksey Shipilev wrote:
> On 1/29/20 4:45 AM, Andrew John Hughes wrote:
>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8238076/webrev.01/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8238076
> 
> Looks fine.
> 
> There are little nits that could be fixed, but no need if that invalidates testing already done.
> 
> For example:
>  - interfaces are implicitly static, so "static interface" is redundant
>  - "delimiter" can be final
>  - "elements" can be final and eagerly initialized in constructor
>  - "elements" can be ArrayList
> 

Forgot to mention for a second time that it does produce identical files
to those from the unpatched tool.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list