[RFR] [8u-JFR] 8238076: Fix OpenJDK 7 Bootstrap Broken by JFR Backport

Aleksey Shipilev shade at redhat.com
Wed Jan 29 08:27:49 UTC 2020


On 1/29/20 9:23 AM, Andrew John Hughes wrote:
> Fixed: https://cr.openjdk.java.net/~andrew/openjdk8/8238076/webrev.02/

Yeah, that's good.

>>  - "elements" can be ArrayList
>>
> Hmm... it can also be a LinkedList and, given this is a case where we
> only append and then finally iterate over the whole list sequentially,
> it seemed a good case for one. Not that it makes much difference either
> way in a build tool.

It does not make much of the difference here.

Performance-wise, I think the only reason to prefer LinkedList over ArrayList if you do
insertions/deletions in weird places (like, in the head). It almost never happens, so my goto
performance optimization is usually a blind s/LinkedList/ArrayList/g :D

-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list