[8u] RFR: 8249677: Regression after JDK-8237117: Better ForkJoinPool behavior

[Anton Kozlov]

Hi,

thanks, a test case was my intention. I was playing with tests, while the fix can be reviewed.

I see an another change in the behavior in defaultForkJoinThreadFactory. Please check the "default" testcase, which passes on openjdk8u252 and does not pass on openjdk8u262.

  http://cr.openjdk.java.net/~akozlov/8249677/webrev.01/

I'm also attaching a standalone testcase to the bug.

The vulnerability group is likely to be a better place to discuss this.
Please consider this as something searchable for anyone who meets with the issue

Thanks,
Anton

On 20.07.2020 17:09, Andrew Hughes wrote:
> 
> 
> On 20/07/2020 14:52, Severin Gehwolf wrote:
>> Hi Anton,
>>
>> On Mon, 2020-07-20 at 11:37 +0300, Anton Kozlov wrote:
>>> On 20.07.2020 08:40, Chris Hegarty wrote:
>>>> A solution that reverts the change to the protected constructor,
>>>> and adds a package-private constructor that does the necessary ACC
>>>> restricting, in a similar way to that of the code in 11u, would
>>>> appear most appropriate here.
>>>
>>> Thank you for the comment, I've prepared a fix that follows this way:
>>>
>>>   http://cr.openjdk.java.net/~akozlov/8249677/webrev.00/
>>>
>>> The change also brings consistency with observable jdk11u logic. The
>>> test case from lucene-solr passes after applying this, as well as
>>> Test.java supplied to the bug.
>>
>> Couldn't we include a regression test with the fix based on Test.java
>> Like so:
>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8249677/jdk8/01/webrev/
>>
>> Thanks,
>> Severin
>>
> 
> That sounds a good idea.
>