[8u] RFR: 8249677: Regression after JDK-8237117: Better ForkJoinPool behavior

[Andrew Hughes]

On 20/07/2020 14:52, Severin Gehwolf wrote:
> Hi Anton,
> 
> On Mon, 2020-07-20 at 11:37 +0300, Anton Kozlov wrote:
>> On 20.07.2020 08:40, Chris Hegarty wrote:
>>> A solution that reverts the change to the protected constructor,
>>> and adds a package-private constructor that does the necessary ACC
>>> restricting, in a similar way to that of the code in 11u, would
>>> appear most appropriate here.
>>
>> Thank you for the comment, I've prepared a fix that follows this way:
>>
>>   http://cr.openjdk.java.net/~akozlov/8249677/webrev.00/
>>
>> The change also brings consistency with observable jdk11u logic. The
>> test case from lucene-solr passes after applying this, as well as
>> Test.java supplied to the bug.
> 
> Couldn't we include a regression test with the fix based on Test.java
> Like so:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8249677/jdk8/01/webrev/
> 
> Thanks,
> Severin
> 

That sounds a good idea.
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222