[8u] TLSv1.3 RFR: 8245477: Adjust TLS tests location

[Alexey Bakhtin]

Hello Martin,

> On 28 Jul 2020, at 01:15, Martin Balao <mbalao at redhat.com> wrote:
> 
> Hi Alexey,
> 
> A few comments on Webrev.01 below.
> 
> 1
> -------------
> 
> Apparently, JDK-8 has 2 SSLSocketTemplate.java files:
> 'sun/security/ssl/templates/SSLSocketTemplate.java' and
> 'javax/net/ssl/templates/SSLSocketTemplate.java'. Looks like the
> javax/net/ssl one was introduced in the context of backporting 8163237
> to 8u. On the other had, there could be tests relocated from
> 'test/sun/security/ssl/javax/net/ssl' to 'test/javax/net/ssl' that were
> using SSLSocketTemplate.java switching between a JDK-8 and JDK-11
> version of it. However, even if this potential case happened, it
> shouldn't be a problem as you observed no regressions. So my question
> is: can we remove 'sun/security/ssl/templates/SSLSocketTemplate.java'?

You are right. sun/security/ssl/templates/SSLSocketTemplate.java
is not required any more and removed in Step 10
No changes in Step 9 required.
> 
> 2
> -------------
> Shouldn't we relocate 'test/sun/security/ssl/README' to
> 'test/javax/net/ssl/README' (which is part of 8032473)?
> 

Yes, you are right.
Should be moved to 'test/javax/net/ssl/README’

> 3
> -------------
> The alignment under 'test/sun/net/www/httpstest' does not look good to me.
> 
> 8032473:
> 
> test/sun/net/www/protocol/https/AbstractCallback.java (new)
> test/sun/net/www/protocol/https/ChunkedOutputStream.java (new)
> test/sun/net/www/protocol/https/ClosedChannelList.java (new)
> test/sun/net/www/protocol/https/HttpCallback.java (new)
> test/sun/net/www/protocol/https/HttpTransaction.java (new)
> test/sun/net/www/protocol/https/TestHttpsServer.java (new)
> 
> Step 9 - Webrev.01:
> 
> test/sun/net/www/https/ChunkedOutputStream/Test.java (new)
> test/sun/net/www/httpstest/AbstractCallback.java (new)
> test/sun/net/www/httpstest/ClosedChannelList.java (new)
> test/sun/net/www/httpstest/HttpCallback.java (new)
> test/sun/net/www/httpstest/HttpTransaction.java (new)
> test/sun/net/www/httpstest/TestHttpsServer.java (new)
> 
> We have differences in the directory ('protocol' vs 'httpstest') and in
> one of the file names ('ChunkedOutputStream.java' vs
> 'ChunkedOutputStream/Test.java').

Yes, you are right. These tests should be moved to sun/net/www/protocol/https
Also, I've renamed ChunkedOutputStream/Test.java to ChunkedOutputStream.java as you suggested

New version is available at : http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245477/webrev.v2/

Regards
Alexey
> 
> Thanks,
> Martin.-
>