[8u] TLSv1.3 RFR: 8245477: Adjust TLS tests location
Martin Balao
mbalao at redhat.com
Mon Jul 27 22:15:17 UTC 2020
Hi Alexey,
A few comments on Webrev.01 below.
1
-------------
Apparently, JDK-8 has 2 SSLSocketTemplate.java files:
'sun/security/ssl/templates/SSLSocketTemplate.java' and
'javax/net/ssl/templates/SSLSocketTemplate.java'. Looks like the
javax/net/ssl one was introduced in the context of backporting 8163237
to 8u. On the other had, there could be tests relocated from
'test/sun/security/ssl/javax/net/ssl' to 'test/javax/net/ssl' that were
using SSLSocketTemplate.java switching between a JDK-8 and JDK-11
version of it. However, even if this potential case happened, it
shouldn't be a problem as you observed no regressions. So my question
is: can we remove 'sun/security/ssl/templates/SSLSocketTemplate.java'?
2
-------------
Shouldn't we relocate 'test/sun/security/ssl/README' to
'test/javax/net/ssl/README' (which is part of 8032473)?
3
-------------
The alignment under 'test/sun/net/www/httpstest' does not look good to me.
8032473:
test/sun/net/www/protocol/https/AbstractCallback.java (new)
test/sun/net/www/protocol/https/ChunkedOutputStream.java (new)
test/sun/net/www/protocol/https/ClosedChannelList.java (new)
test/sun/net/www/protocol/https/HttpCallback.java (new)
test/sun/net/www/protocol/https/HttpTransaction.java (new)
test/sun/net/www/protocol/https/TestHttpsServer.java (new)
Step 9 - Webrev.01:
test/sun/net/www/https/ChunkedOutputStream/Test.java (new)
test/sun/net/www/httpstest/AbstractCallback.java (new)
test/sun/net/www/httpstest/ClosedChannelList.java (new)
test/sun/net/www/httpstest/HttpCallback.java (new)
test/sun/net/www/httpstest/HttpTransaction.java (new)
test/sun/net/www/httpstest/TestHttpsServer.java (new)
We have differences in the directory ('protocol' vs 'httpstest') and in
one of the file names ('ChunkedOutputStream.java' vs
'ChunkedOutputStream/Test.java').
Thanks,
Martin.-
More information about the jdk8u-dev
mailing list