[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

Mario Torre neugens at redhat.com
Sat Jun 6 22:32:13 UTC 2020


Hi Andrew,

Without this patch the JVM segfaults when an agent tries to use JFR while
collecting startup events.

I agree on the general case but this one seems important to have it in, but
this of course unless there are issues with the actual code.

Cheers,
Mario

On Saturday, June 6, 2020, Andrew Hughes <gnu.andrew at redhat.com> wrote:

>
>
> On 03/06/2020 12:15, Mario Torre wrote:
>
> snip...
> >
> >> BTW, since this patch missed the cutoff date for 8u262 mostly due to
> >> review would it be ok to consider it still as a part of the critical
> >> fix process?
> >
> > I most certainly support this.
> >
> > Cheers,
> > Mario
> >
>
> My initial thought is that, if a patch takes a long time in review,
> that's probably a sign that it required a lot of debate and alteration,
> and so shouldn't be going into a release late, rather than the opposite.
>
> However, I'm of course open to hearing why this is critical to the 8u262
> release and can't wait until 8u272.
>
> Thanks,
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>
>

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com><br>9704 A60C B4BE A8B8 0F30
9205 5D7E 4952 3F65 7898


More information about the jdk8u-dev mailing list