[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Jaroslav Bachorík]

On Sat, Jun 6, 2020 at 11:40 PM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>
>
>
> On 03/06/2020 12:15, Mario Torre wrote:
>
> snip...
> >
> >> BTW, since this patch missed the cutoff date for 8u262 mostly due to
> >> review would it be ok to consider it still as a part of the critical
> >> fix process?
> >
> > I most certainly support this.
> >
> > Cheers,
> > Mario
> >
>
> My initial thought is that, if a patch takes a long time in review,
> that's probably a sign that it required a lot of debate and alteration,
> and so shouldn't be going into a release late, rather than the opposite.

I do not think this is a good example of a contentious issue. The RFR
spent most of its time being idle waiting for review - the only issues
were related to formatting and non-existent test (which does not exist
upstream either). So the point about debate and alteration is rather
moot here.

>
> However, I'm of course open to hearing why this is critical to the 8u262
> release and can't wait until 8u272.

Well, not having JVM segfault on a valid use of JFR would be nice. But
it's your call as the maintainer.

Cheers,

-JB-

>
> Thanks,
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>