RFR: 8245167: Top package in method profiling shows "null" in JMC

[Jaroslav Bachorík]

Hi,

I have labelled the JIRA issue.

Cheers,

-JB-

On Thu, Jun 11, 2020 at 8:50 PM Mario Torre
<neugens.limasoftware at gmail.com> wrote:
>
> Hi Andrey,
>
> I think we need a similar treatment as for 8233197. Can you please flag the bug as jdk8u-critical-fix?
>
> Cheers,
> Mario
>
> On Mon 8. Jun 2020 at 20:58, Mario Torre <neugens at redhat.com> wrote:
>>
>> On Mon, Jun 8, 2020 at 1:27 PM Jaroslav Bachorík
>> <jaroslav.bachorik at datadoghq.com> wrote:
>> >
>> > On Wed, Jun 3, 2020 at 1:05 PM Mario Torre <neugens at redhat.com> wrote:
>> > >
>> > > On Wed, Jun 3, 2020 at 12:15 PM Andrey Petushkov <andrey at azul.com> wrote:
>> > > >
>> > > > Hi Andrew,
>> > > >
>> > > > This 'L' -checking code is activated only when the method in question is
>> > > > given the array (i.e. the FQN of the class is something "[L...").
>> > > > However the caller never applies the method to array classes, only
>> > > > instance classes.
>> > > > (and I've actually checked that "L.Main" class has appeared in the JMC's
>> > > > "Top packages" window)
>> > >
>> > > Yeah, however it's not clear to me if this may change in the future
>> > > since the function has a side effect that it's not entirely specified,
>> > > that said however I think, if any, this is a bug in mainline and an
>> > > eventual fix should come in via an additional backport and not hold
>> > > this fix in 8u.
>> >
>> > Totally agreed - this should be done asynchronously and not held back
>> > by an issue in the mainline.
>>
>> Absolutely, from my side this patch is reviewed and approved, but we
>> need a maintainer to approve the merge in JDK8u.
>>
>> Cheers,
>> Mario
>>
>>
>> --
>> Mario Torre
>> Associate Manager, Software Engineering
>> Red Hat GmbH <https://www.redhat.com>
>> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>>
> --
> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
> Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF
>
> Java Champion - Blog: http://neugens.wordpress.com - Twitter: @neugens
> Proud GNU Classpath developer: http://www.classpath.org/
> OpenJDK: http://openjdk.java.net/projects/caciocavallo/
>
> Please, support open standards:
> http://endsoftpatents.org/