RFR: 8245167: Top package in method profiling shows "null" in JMC

[Andrew Hughes]

On 12/06/2020 09:37, Jaroslav Bachorík wrote:
> Hi,
> 
> I have labelled the JIRA issue.
> 
> Cheers,
> 
> -JB-
> 

I've approved this. However, in future, please add a comment when adding
the label in future, stating why it should be approved. This is
especially important when you're requesting a critical approval during
rampdown.

In this case, I think the patch is safe, as it adds a function which is
then only called from JFR code, which is new in 8u262 (and thus, by
definition, can't regress).

But, please try to get such changes in before rampdown in future. I
realise this was held up waiting for reviewers, so that's as much an
appeal to reviewers to be pro-active as it is those submitting patches
for review.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222