RFR: 8245167: Top package in method profiling shows "null" in JMC
Andrey Petushkov
andrey at azul.com
Mon Jun 15 11:21:34 UTC 2020
Pushed
Sorry for the delay, there were state holidays.
Thank you all, especially Jaroslav for not letting this slip away from
8u262!
Regards,
Andrey
On 12.06.2020 17:55, Andrew Hughes wrote:
> On 12/06/2020 09:37, Jaroslav Bachorík wrote:
>> Hi,
>>
>> I have labelled the JIRA issue.
>>
>> Cheers,
>>
>> -JB-
>>
> I've approved this. However, in future, please add a comment when adding
> the label in future, stating why it should be approved. This is
> especially important when you're requesting a critical approval during
> rampdown.
>
> In this case, I think the patch is safe, as it adds a function which is
> then only called from JFR code, which is new in 8u262 (and thus, by
> definition, can't regress).
>
> But, please try to get such changes in before rampdown in future. I
> realise this was held up waiting for reviewers, so that's as much an
> appeal to reviewers to be pro-active as it is those submitting patches
> for review.
>
> Thanks,
More information about the jdk8u-dev
mailing list